WPPizza – A Restaurant Plugin for WordPress › Support › General Support › Additives numbering – first three skip one number (-1)
- AuthorPosts
- 12 May, 2017 at 7:42 pm #27675
PS: might also be one of the other plugins you have there like “site origin widget” or something
only way to really narrow it down is disable all other (non-wppizza) plugins and reenable one by one .
(same goes for theme as mentioned above)13 May, 2017 at 7:54 am #27690I just disabled WPML String translation and it works fine (numbering works as it should).
Can’t be the theme – the content that’s problematic comes from Site Origin Page Builder and WPML, the theme is just the skeleton. Tried changing the theme just to be sure – no change.
I even deleted all the big text chunk strings, still no change which is strange. Will take it to the Site Origin forum.
Seems to me that WPML is translating Site Origin pages twice:
1. Once as pages (manual translation, creatin language mutations)
2. in-page text as widgets (Site origin works via widgets, most of the text I found in string Widget translation). Which seems a bit of a duplication to me.This can be closed, your plugin is working fine, thanks for your help and time!
Lukas
13 May, 2017 at 10:17 am #27691should anyone come across this issue again, this might help too:
The problem seems to be with the numbering that’s stored in WPML string translation, where item number 1 in wppizza additives is stored as addon_0 in WPML string translation:
https://snag.gy/Sj9yzD.jpgthis is the likely cause why the numbers show differently when WPML string translation is switched on.
I’ll raise it with the WPML team.
13 May, 2017 at 10:42 am #27692this is the WPML support link for this issue: https://wpml.org/forums/topic/wppizza-strings-translation-incorrect-numbering-starts-at-0-instead-of-1/
13 May, 2017 at 2:17 pm #27693>The problem seems to be with the numbering that’s stored in WPML string translation, where item number 1 in wppizza additives is stored as addon_0 in WPML string translation
i very highly doubt that as the _0 is just an array key/identifier for registering the string ….
22 May, 2017 at 10:37 am #27825Hi Olly,
heres the response from WPML – theres a recommendation for you as the author of the plugin at the bottom, so Im passing it on:
Our third tier has checked the issue, and he writes: “the author sorts this in reverse in his code and has added compatibility class for WPML which registers the fields by their fields numbers.”
This issue needs to be checked further by our compatibility team.
I’m escalating this ticket to our compatibility team now.
If they can find a quick fix for this issue, then I’ll share it with you here.
If it is not something that our compatibility team can fix, then it will require the cooperation of the plugin’s author.
It would be great if you could contact the authors and urge them to join our Go Global Program.
You can find details about it here.
https://wpml.org/documentation/theme-compatibility/go-global-program/
We will be happy to cooperate with the authors in making their plugin officially compatible with WPML.22 May, 2017 at 11:51 am #27832I guess I will respond to that thread directly on WPML later.
Suffice to say, some of what they are saying is simply not true (for starters , why would I possibly want to sort this in reverse)
secondly, i also still suggest you use the shortcode associated with listing the additives, not the hack you have been using by entering an id that does not exist.
I understand why you did that – i.e. trying to work around things that seemingly do not work with WPML – but that’s fixing the symptoms not the cause. using your workaround has massive overheads / performance implications .in the meantime I will try to replicate this here with a basic wppizza and wpml setup and see if this is even reproducable as I would have thought if this issue really exist with wppizza and wpml i would have heard about it before. I am still thinking this is elsewhere (but i might be wrong of course, we’ll see)
22 May, 2017 at 11:57 am #27833Hi olly,
with regards to the shortcode – you’re confusing the reason why I use it. It has nothing to do with WPML and the issue with numbering.
Your suggested shortcode [wppizza type=’additives’] produces a strange unordered list of additives (or their shortcuts, no idea): https://snag.gy/s8mvWz.jpg
What I need (and what my workaround shortcode produces) is this: https://snag.gy/HAdYFP.jpg although with the correct numbering (which we now know is WPML issue.)
22 May, 2017 at 12:17 pm #27834>you’re confusing the reason why I use it
no, i know why you are using it>produces a strange unordered list of
yes, that’s the idea (although obviously a full list , not the truncated array you get at https://snag.gy/s8mvWz.jpg ). it’s an unstyled list. there’s nothing “strange” about it. it has tons of classes and things wrapped in elements . you could simply add the same css used for the ones that are being used when using your workaround shortcodehowever, evidently, suggested shortcode produces a – shall we say – unwanted result in your case which i can assure you it does not normally. hence i believe the issue is elsewhere. Again, you/we are fixing the symptoms, not the cause
So, first of all, do you also get this truncated array(i/e mess) your end using the recommended shortcode, but WPML turned off ?
22 May, 2017 at 12:51 pm #27835just a quick update.
this is quite interesting. using a vanilla install of WP, WPML and WPPizza and the shortcode [wppizza type=”additives”] does exactly as you describe. (i.e it shows a truncated messed up list). as soon as i turn off WPML its all there again as it should be.
i shall mess around with a couple of things here. perhaps it really is a WPML problem after all.
usually i think it’s either my issue or elsewhere….anyway will keep you posted here and on the WPML thread when i know some more, and while i am at it , I might also try and find out why the ordering is strange when you use your workaround shortcode
22 May, 2017 at 12:52 pm #27836I am kind of surprised nobody mentioned this before though, but then again, maybe this issue did not exist with previous/old WPML versions…who k nows
22 May, 2017 at 12:55 pm #27837>>you’re confusing the reason why I use it
>no, i know why you are using itactually, i lied. I only paid attention to one of the issues (the names being truncated – not the numbering being wrong).
apologies, i have to fix that22 May, 2017 at 1:03 pm #27838ok, thanks for digging in 🙂
for now, I’ll stick to the workaround shortcode and wait for udpates from you & WPML.
22 May, 2017 at 1:43 pm #27842>ok, thanks for digging in
no problem, thanks for reporting and helping to get to the bottom of it>for now, I’ll stick to the workaround shortcode and wait for udpates from you & WPML
good plani think i should have this fixed later today, if it turns out it’s all down to me/wppizza
22 May, 2017 at 2:38 pm #27843as of wppizza version 2.16.11.24 , i believe this is now fixed and was due to some legacy coding left in the plugin for very old wppizza versions (in case anyone cares reading this :))
had nothing to do with WPML or any other non-wppizza plugins. simple coding error on my behalf
obviously, if there are still issues for some reason, let me know
PS: might take a couple of minutes for that update to show up in your plugins page
22 May, 2017 at 3:02 pm #27844updated and it works. thanks for such a quick implementation of the fix 🙂
I’ll update the WPML thread too.
22 May, 2017 at 3:05 pm #27845>updated and it works.
hooray>thanks for such a quick implementation of the fix
no problem>I’ll update the WPML thread too.
thank you - AuthorPosts
- The topic ‘Additives numbering – first three skip one number (-1)’ is closed to new replies.